MTG-12 use custom detekt rule#1233
Merged
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/MTG-12/detekt_custom_rules
branch
from
January 17, 2023 16:54
59a872f to
85f0ca8
Compare
xgouchet
marked this pull request as ready for review
January 17, 2023 17:06
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1233 +/- ##
===========================================
+ Coverage 82.31% 82.33% +0.02%
===========================================
Files 353 353
Lines 11795 11802 +7
Branches 2007 2008 +1
===========================================
+ Hits 9708 9716 +8
+ Misses 1475 1474 -1
Partials 612 612 |
0xnm
approved these changes
Jan 18, 2023
mariusc83
approved these changes
Jan 18, 2023
daniel-m-dd
approved these changes
Jan 19, 2023
| DETEKT_PUBLIC_API: "true" | ||
| DETEKT_CUSTOM_RULES_BUILD_TASK: ":tools:detekt:jar" | ||
| DETEKT_CUSTOM_RULES_JAR_PATH: "tools/detekt/build/libs/detekt.jar" | ||
| DETEKT_CUSTOM_RULES_YML_PATH: "detekt_custom.yml" |
Contributor
There was a problem hiding this comment.
this goes surely too deep for now but what do you think about just pointing to a file, say datadog-static-analysis-detekt-config.{yml/json...} (couldnt care less about the format), where all these variables would be defined; giving more freedom to each project, and bonus :
- avoid an ever grwoing list of env variable
- file versioned in each project (so less "magic"; somebody could rename the task on one project not being aware it is used by
dd-source)
Contributor
Author
There was a problem hiding this comment.
Yeah that makes sense, but indeed maybe this is going too deep for now ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)