Skip to content

Cherry-pick: RUMM-2868: Apply extra sampling rate to the configuration telemetry#1225

Merged
0xnm merged 1 commit into
release/1.16.0from
nogorodnikov/cherry-pick-extra-configuration-sampling-into-1.16.0
Jan 10, 2023
Merged

Cherry-pick: RUMM-2868: Apply extra sampling rate to the configuration telemetry#1225
0xnm merged 1 commit into
release/1.16.0from
nogorodnikov/cherry-pick-extra-configuration-sampling-into-1.16.0

Conversation

@0xnm

@0xnm 0xnm commented Jan 9, 2023

Copy link
Copy Markdown
Member

What does this PR do?

This PR is a cherry-pick of #1222 into release/1.16.0 branch.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner January 9, 2023 16:39
@codecov-commenter

codecov-commenter commented Jan 9, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1225 (408591f) into release/1.16.0 (f587e0f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           release/1.16.0    #1225      +/-   ##
==================================================
+ Coverage           82.47%   82.49%   +0.01%     
==================================================
  Files                 353      353              
  Lines               11827    11830       +3     
  Branches             2013     2014       +1     
==================================================
+ Hits                 9754     9758       +4     
- Misses               1460     1461       +1     
+ Partials              613      611       -2
Impacted Files Coverage Δ
.../main/kotlin/com/datadog/android/rum/RumMonitor.kt 76.60% <100.00%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.95% <100.00%> (+0.68%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 71.43% <0.00%> (-14.29%) ⬇️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 95.83% <0.00%> (-4.17%) ⬇️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 80.77% <0.00%> (-3.85%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.70% <0.00%> (+0.99%) ⬆️
...android/v2/core/internal/DatadogContextProvider.kt 85.29% <0.00%> (+1.47%) ⬆️
...in/com/datadog/android/log/internal/LogsFeature.kt 88.71% <0.00%> (+1.61%) ⬆️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 97.62% <0.00%> (+2.38%) ⬆️

@0xnm
0xnm merged commit 4251756 into release/1.16.0 Jan 10, 2023
@0xnm
0xnm deleted the nogorodnikov/cherry-pick-extra-configuration-sampling-into-1.16.0 branch January 10, 2023 08:29
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @xgouchet