Skip to content

RUMM-2868: Apply extra sampling rate to the configuration telemetry#1222

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rumm-2868/apply-extra-sample-rate-to-configuration-events
Jan 9, 2023
Merged

RUMM-2868: Apply extra sampling rate to the configuration telemetry#1222
0xnm merged 1 commit into
developfrom
nogorodnikov/rumm-2868/apply-extra-sample-rate-to-configuration-events

Conversation

@0xnm

@0xnm 0xnm commented Jan 9, 2023

Copy link
Copy Markdown
Member

What does this PR do?

This change applies extra sampling rate (20%) to the configuration telemetry events on top of the telemetry sampling rate configured.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner January 9, 2023 10:31
@codecov-commenter

codecov-commenter commented Jan 9, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.21%. Comparing base (30b1168) to head (f4e3b09).
⚠️ Report is 3671 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1222      +/-   ##
===========================================
- Coverage    82.36%   82.21%   -0.15%     
===========================================
  Files          353      353              
  Lines        11806    11809       +3     
  Branches      2010     2011       +1     
===========================================
- Hits          9723     9708      -15     
- Misses        1472     1478       +6     
- Partials       611      623      +12     
Files with missing lines Coverage Δ
.../main/kotlin/com/datadog/android/rum/RumMonitor.kt 76.60% <100.00%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 69.67% <100.00%> (-2.60%) ⬇️

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm force-pushed the nogorodnikov/rumm-2845/speed-up-sample-app-build-for-codeql-scan branch from 170b981 to 30b1168 Compare January 9, 2023 14:00
@0xnm
0xnm force-pushed the nogorodnikov/rumm-2868/apply-extra-sample-rate-to-configuration-events branch from 3fc0dfa to f4e3b09 Compare January 9, 2023 15:32
Base automatically changed from nogorodnikov/rumm-2845/speed-up-sample-app-build-for-codeql-scan to develop January 9, 2023 15:36
@0xnm
0xnm merged commit cf38803 into develop Jan 9, 2023
@0xnm
0xnm deleted the nogorodnikov/rumm-2868/apply-extra-sample-rate-to-configuration-events branch January 9, 2023 16:23
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants