RUMM-2797 SR RequestFactory allow to throw exceptions#1217
Merged
mariusc83 merged 1 commit intoJan 6, 2023
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-2797/sr-request-factory-throw-exceptions
branch
3 times, most recently
from
January 5, 2023 13:21
3046306 to
c410c64
Compare
mariusc83
marked this pull request as ready for review
January 5, 2023 13:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/sdkv2 #1217 +/- ##
=================================================
- Coverage 82.72% 82.64% -0.09%
=================================================
Files 353 354 +1
Lines 12589 12572 -17
Branches 2086 2085 -1
=================================================
- Hits 10414 10389 -25
- Misses 1535 1542 +7
- Partials 640 641 +1
🚀 New features to boost your workflow:
|
0xnm
approved these changes
Jan 5, 2023
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
I left some comments, but overall ltgm.
| @Suppress("UnsafeThirdPartyFunctionCall") | ||
| body.writeTo(buffer) | ||
| @Suppress("UnsafeThirdPartyFunctionCall") | ||
| return buffer.readByteArray() |
Member
There was a problem hiding this comment.
this readByteArray method is strange - it says that it can throw IOException, but the actual implementation actually can also throw Error:
try {
return readByteArray(size);
} catch (EOFException e) {
throw new AssertionError(e);
}
Do you think we should catch it? Because the outer code only handles exceptions, but not errors. Normally errors are not recoverable though, so maybe we don't need to.
Member
Author
There was a problem hiding this comment.
yeah...that's the thing...I would leave errors not caught ...it will be another thread anyway not the main thread.
|
|
||
| package com.datadog.android.sessionreplay.internal.exception | ||
|
|
||
| internal class InvalidPayloadFormatException(message: String) : Exception(message) |
Member
There was a problem hiding this comment.
Let's make it extend RuntimeException, so that it is not checked one.
Suggested change
| internal class InvalidPayloadFormatException(message: String) : Exception(message) | |
| internal class InvalidPayloadFormatException(message: String) : RuntimeException(message) |
mariusc83
force-pushed
the
mconstantin/rumm-2797/sr-request-factory-throw-exceptions
branch
from
January 6, 2023 08:47
c410c64 to
06e0a88
Compare
mariusc83
deleted the
mconstantin/rumm-2797/sr-request-factory-throw-exceptions
branch
January 6, 2023 09:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)