RUMM-2516: Remove cross platform duplicates crashes#1215
Merged
louiszawadzki merged 2 commits intoJan 18, 2023
Merged
Conversation
mariusc83
reviewed
Jan 4, 2023
| val updatedAttributes = addExtraAttributes(event.attributes) | ||
| val isFatal = updatedAttributes.remove(RumAttributes.INTERNAL_ERROR_IS_CRASH) as? Boolean | ||
| val isFatal = updatedAttributes.remove(RumAttributes.INTERNAL_ERROR_IS_CRASH) as? Boolean == true || event.isFatal | ||
| if (crashCount > 0 && isFatal) return // if a cross-platform crash was already reported, do not send its native version |
Member
There was a problem hiding this comment.
This could work only if we are sure there's not going to be another fatal crash reported after this.
Contributor
There was a problem hiding this comment.
If the crash is fatal, none could be reported after.
louiszawadzki
force-pushed
the
louiszawadzki/rumm-2516/prevent-cross-plaform-crashes-duplicates
branch
2 times, most recently
from
January 16, 2023 09:54
aef427e to
aed2293
Compare
louiszawadzki
marked this pull request as ready for review
January 16, 2023 09:54
xgouchet
approved these changes
Jan 16, 2023
louiszawadzki
force-pushed
the
louiszawadzki/rumm-2516/prevent-cross-plaform-crashes-duplicates
branch
from
January 17, 2023 15:09
aed2293 to
1e3a82d
Compare
louiszawadzki
deleted the
louiszawadzki/rumm-2516/prevent-cross-plaform-crashes-duplicates
branch
January 18, 2023 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Remove duplicated errors for JS crashes in React Native.
I'm not sure why we had 2 different behaviours in the first place depending on whether the crash was cross-platform or native: #764
Review checklist (to be filled by reviewers)