RUMM-2796 RequestFactory can throw exceptions#1214
Merged
mariusc83 merged 1 commit intoJan 5, 2023
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-2796/request-factory-can-throw-exceptions
branch
2 times, most recently
from
January 4, 2023 09:51
3659546 to
3da65f5
Compare
0xnm
approved these changes
Jan 4, 2023
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
I've left few suggestion, but overall lgtm.
| internal enum class UploadStatus(val shouldRetry: Boolean) { | ||
| SUCCESS(shouldRetry = false), | ||
| NETWORK_ERROR(shouldRetry = true), | ||
| INVALID_REQUEST_ERROR(shouldRetry = false), |
Member
There was a problem hiding this comment.
I would suggest something like REQUEST_CREATION_ERROR, because INVALID_REQUEST_ERROR may have a meaning that request was sent, but was rejected by the server (code 400, which is currently backed by HTTP_CLIENT_ERROR).
|
|
||
| @Test | ||
| fun `M return InvalidRequestError W upload() { request factory throws }`( | ||
| @Forgery fakeException: java.lang.Exception, |
Member
There was a problem hiding this comment.
Suggested change
| @Forgery fakeException: java.lang.Exception, | |
| @Forgery fakeException: Exception, |
|
|
||
| @Test | ||
| fun `M log the exception to telemetry W upload() { request factory throws }`( | ||
| @Forgery fakeException: java.lang.Exception, |
Member
There was a problem hiding this comment.
Suggested change
| @Forgery fakeException: java.lang.Exception, | |
| @Forgery fakeException: Exception, |
mariusc83
force-pushed
the
mconstantin/rumm-2796/request-factory-can-throw-exceptions
branch
from
January 4, 2023 11:55
3da65f5 to
82208f3
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2796/request-factory-can-throw-exceptions
branch
from
January 4, 2023 12:17
82208f3 to
b31891b
Compare
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1214 +/- ##
=================================================
+ Coverage 82.65% 82.69% +0.04%
=================================================
Files 353 353
Lines 12537 12545 +8
Branches 2075 2073 -2
=================================================
+ Hits 10362 10374 +12
+ Misses 1537 1535 -2
+ Partials 638 636 -2
|
xgouchet
reviewed
Jan 4, 2023
| val request = requestFactory.create(context, batch, batchMeta) | ||
| val request = try { | ||
| requestFactory.create(context, batch, batchMeta) | ||
| } catch (e: Exception) { |
Contributor
There was a problem hiding this comment.
DO we have more information on what type of exception can happen? Or is this just hypothetical?
Member
Author
There was a problem hiding this comment.
unfortunately we don't. For example in case of SR it can be because of a bad payload format but in other cases it may be something else. I followed what iOS is doing also and I saw they also have it generic.
xgouchet
approved these changes
Jan 5, 2023
mariusc83
deleted the
mconstantin/rumm-2796/request-factory-can-throw-exceptions
branch
January 5, 2023 09:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)