Skip to content

RUMM-2828: Send logs for Span using message bus#1211

Merged
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2828/send-logs-for-span-using-message-bus
Jan 4, 2023
Merged

RUMM-2828: Send logs for Span using message bus#1211
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2828/send-logs-for-span-using-message-bus

Conversation

@0xnm

@0xnm 0xnm commented Jan 3, 2023

Copy link
Copy Markdown
Member

What does this PR do?

This change removes direct dependency between AndroidSpanLogsHandler and Logger to allow sending logs for the particular span (via Span.log API) using message bus.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner January 3, 2023 10:00
@codecov-commenter

codecov-commenter commented Jan 3, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1211 (9bd0b15) into feature/sdkv2 (555764f) will increase coverage by 0.00%.
The diff coverage is 85.94%.

@@              Coverage Diff               @@
##           feature/sdkv2    #1211   +/-   ##
==============================================
  Coverage          82.65%   82.65%           
==============================================
  Files                353      353           
  Lines              12537    12568   +31     
  Branches            2075     2084    +9     
==============================================
+ Hits               10362    10388   +26     
+ Misses              1537     1536    -1     
- Partials             638      644    +6
Impacted Files Coverage Δ
...in/com/datadog/android/log/internal/LogsFeature.kt 85.38% <81.82%> (-0.75%) ⬇️
...racing/internal/handlers/AndroidSpanLogsHandler.kt 91.84% <94.74%> (+1.59%) ⬆️
...otlin/com/datadog/android/tracing/AndroidTracer.kt 94.37% <100.00%> (-0.08%) ⬇️
...android/log/internal/logger/TelemetryLogHandler.kt 71.43% <0.00%> (-14.29%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.80% <0.00%> (-1.60%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.18% <0.00%> (-0.36%) ⬇️
...id/rum/internal/ndk/DatadogNdkCrashEventHandler.kt 91.00% <0.00%> (ø)
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 86.69% <0.00%> (+0.40%) ⬆️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 97.37% <0.00%> (+2.63%) ⬆️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 86.67% <0.00%> (+3.33%) ⬆️
... and 1 more

@mariusc83 mariusc83 assigned mariusc83 and unassigned mariusc83 Jan 3, 2023
mariusc83
mariusc83 approved these changes Jan 3, 2023
View reviewed changes

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xnm
0xnm merged commit 5f7d799 into feature/sdkv2 Jan 4, 2023
@0xnm
0xnm deleted the nogorodnikov/rumm-2828/send-logs-for-span-using-message-bus branch January 4, 2023 10:47
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83