RUMM-2038 Use safe context for directBootAware host apps#1209
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/RUMM-2038/direct_boot_mode
branch
from
December 30, 2022 10:01
d6747f1 to
3875e69
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1209 +/- ##
===========================================
- Coverage 82.31% 82.29% -0.02%
===========================================
Files 353 353
Lines 11795 11799 +4
Branches 2007 2009 +2
===========================================
+ Hits 9708 9709 +1
- Misses 1475 1476 +1
- Partials 612 614 +2
|
apigirl
approved these changes
Dec 30, 2022
apigirl
left a comment
apigirl
left a comment
Contributor
There was a problem hiding this comment.
just some small nits, otherwise looks good for docs
Co-authored-by: Kaylyn <[email protected]>
0xnm
approved these changes
Jan 2, 2023
Comment on lines
+285
to
+289
| // When the host app uses the `directBootAware` flag on a file encrypted device, | ||
| // the app can wake up during the boot sequence before the device is unlocked | ||
| // This mean any file I/O or access to shared preferences will throw an exception | ||
| // This safe context creates a device-protected storage which can be used for non sensitive | ||
| // data. It should not be used to store the data captured by the SDK. |
Member
There was a problem hiding this comment.
Suggested change
| // When the host app uses the `directBootAware` flag on a file encrypted device, | |
| // the app can wake up during the boot sequence before the device is unlocked | |
| // This mean any file I/O or access to shared preferences will throw an exception | |
| // This safe context creates a device-protected storage which can be used for non sensitive | |
| // data. It should not be used to store the data captured by the SDK. | |
| // When the host app uses the `directBootAware` flag on a file encrypted device, | |
| // the app can wake up during the boot sequence before the device is unlocked | |
| // This mean any file I/O or access to shared preferences will throw an exception | |
| // This safe context creates a device-protected storage which can be used for non-sensitive | |
| // data. It should not be used to store the data captured by the SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #854
Fixes #1116
What does this PR do?
Uses the
createDeviceProtectedStorageContextto ensure Kronos works in all edge cases.Note that the safe context should only be used for Kronos.