Fix flaky WireframeUtils test#1208
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/sdkv2 #1208 +/- ##
==============================================
Coverage 82.59% 82.59%
==============================================
Files 351 351
Lines 12480 12475 -5
Branches 2058 2056 -2
==============================================
- Hits 10307 10303 -4
- Misses 1533 1535 +2
+ Partials 640 637 -3 🚀 New features to boost your workflow:
|
xgouchet
approved these changes
Dec 28, 2022
mariusc83
reviewed
Jan 2, 2023
| ) | ||
|
|
||
| val fakeRandomParents: List<MobileSegment.Wireframe> = forge.aList<MobileSegment.Wireframe> { | ||
| val fakeRandomParents: List<MobileSegment.Wireframe> = forge.aList { |
Member
There was a problem hiding this comment.
I think I fixed this also in my current PR
mariusc83
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fixes flaky
M return false W checkIsValidWireframe(){ covered by another with solid background }test.Test was failing because there was a possibility to generate wireframe without background color, so it has
isOpaque == false.Review checklist (to be filled by reviewers)