Skip to content

MTG-8 use latest version of shared pipeline#1201

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/MTG-8/conditional_detekt_job
Dec 22, 2022
Merged

MTG-8 use latest version of shared pipeline#1201
xgouchet merged 1 commit into
developfrom
xgouchet/MTG-8/conditional_detekt_job

Conversation

@xgouchet

@xgouchet xgouchet commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Bump the pipeline dependency (cf dd-source#21171 )

@xgouchet
xgouchet requested a review from a team as a code owner December 20, 2022 14:59
0xnm
0xnm approved these changes Dec 21, 2022
View reviewed changes
Comment thread dd-sdk-android/src/main/kotlin/com/datadog/android/core/internal/sampling/Sampler.kt Outdated

internal interface Sampler {


@0xnm 0xnm Dec 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems this one should be reverted

@xgouchet
xgouchet force-pushed the xgouchet/MTG-8/conditional_detekt_job branch from abf5060 to 1301b7f Compare December 21, 2022 13:56
@codecov-commenter

codecov-commenter commented Dec 21, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1201 (1301b7f) into develop (e707d40) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1201      +/-   ##
===========================================
+ Coverage    82.31%   82.33%   +0.03%     
===========================================
  Files          353      353              
  Lines        11795    11790       -5     
  Branches      2007     2005       -2     
===========================================
- Hits          9708     9707       -1     
+ Misses        1475     1474       -1     
+ Partials       612      609       -3
Impacted Files Coverage Δ
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-2.94%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 95.24% <0.00%> (-2.38%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.70% <0.00%> (-0.49%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 89.86% <0.00%> (-0.46%) ⬇️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 80.77% <0.00%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.27% <0.00%> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 95.42% <0.00%> (+0.18%) ⬆️
...android/log/internal/domain/DatadogLogGenerator.kt 97.32% <0.00%> (+1.34%) ⬆️
...in/com/datadog/android/log/internal/LogsFeature.kt 91.94% <0.00%> (+3.23%) ⬆️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 78.85% <0.00%> (+3.85%) ⬆️
... and 2 more

@xgouchet
xgouchet merged commit 416f468 into develop Dec 22, 2022
@xgouchet
xgouchet deleted the xgouchet/MTG-8/conditional_detekt_job branch December 22, 2022 08:10
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@xgouchet @codecov-commenter @0xnm