Skip to content

RUMM-2764: Use InternalLogger#1200

Merged
0xnm merged 2 commits into
feature/sdkv2from
nogorodnikov/rumm-2764/use-internal-logger
Dec 20, 2022
Merged

RUMM-2764: Use InternalLogger#1200
0xnm merged 2 commits into
feature/sdkv2from
nogorodnikov/rumm-2764/use-internal-logger

Conversation

@0xnm

@0xnm 0xnm commented Dec 19, 2022

Copy link
Copy Markdown
Member

What does this PR do?

This PR is simple (but big), it introduces internalLogger usage everywhere for the internal purposes, and internalLogger doesn't depend on the log module, so we can use it in the core.

sdkLogger and devLogger are moved into internalLogger and are not accessible from outside.

Also this change makes serialization errors to be shown to the user, because they may be caused by the user code (problems with serialization of user classes, for example).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm force-pushed the nogorodnikov/rumm-2764/use-internal-logger branch from 3a70085 to 7a99513 Compare December 19, 2022 11:47
@0xnm
0xnm force-pushed the nogorodnikov/rumm-2764/use-internal-logger branch from 7a99513 to 32574cb Compare December 19, 2022 12:14
@0xnm
0xnm marked this pull request as ready for review December 19, 2022 12:47
@0xnm
0xnm requested a review from a team as a code owner December 19, 2022 12:47
@codecov-commenter

codecov-commenter commented Dec 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1200 (32574cb) into feature/sdkv2 (ca94f5b) will decrease coverage by 0.59%.
The diff coverage is 78.20%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1200      +/-   ##
=================================================
- Coverage          83.14%   82.55%   -0.59%     
=================================================
  Files                352      351       -1     
  Lines              11862    12472     +610     
  Branches            2052     2052              
=================================================
+ Hits                9862    10296     +434     
- Misses              1362     1535     +173     
- Partials             638      641       +3
Impacted Files Coverage Δ
...ndroid/core/internal/net/GzipRequestInterceptor.kt 64.52% <0.00%> (-15.48%) ⬇️
...core/internal/persistence/file/FileReaderWriter.kt 100.00% <ø> (ø)
...rsistence/file/advanced/FeatureFileOrchestrator.kt 100.00% <ø> (ø)
...al/persistence/file/batch/BatchFileReaderWriter.kt 100.00% <ø> (ø)
...atadog/android/core/internal/utils/ByteArrayExt.kt 71.43% <0.00%> (-9.97%) ⬇️
...droid/core/internal/utils/ComponentPredicateExt.kt 53.85% <0.00%> (-23.93%) ⬇️
...g/android/log/internal/logger/DatadogLogHandler.kt 82.02% <0.00%> (-5.93%) ⬇️
...com/datadog/android/log/internal/utils/LogUtils.kt 100.00% <ø> (ø)
...c/main/kotlin/com/datadog/android/rum/GlobalRum.kt 30.77% <0.00%> (-9.23%) ⬇️
...n/kotlin/com/datadog/android/rum/RumErrorSource.kt 100.00% <ø> (ø)
... and 102 more

@0xnm
0xnm merged commit ecf31a2 into feature/sdkv2 Dec 20, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-2764/use-internal-logger branch December 20, 2022 10:17
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83