Skip to content

Delete obsolete feature-specific uploaders#1199

Merged
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/delete-obsolete-feature-specific-uploaders
Dec 16, 2022
Merged

Delete obsolete feature-specific uploaders#1199
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/delete-obsolete-feature-specific-uploaders

Conversation

@0xnm

@0xnm 0xnm commented Dec 15, 2022

Copy link
Copy Markdown
Member

What does this PR do?

This PR removes some files which are not used anymore (and won't be).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 15, 2022 16:35
mariusc83
mariusc83 approved these changes Dec 15, 2022
View reviewed changes

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They served their purpose well. May they rest in peace now 😄

@codecov-commenter

codecov-commenter commented Dec 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1199 (6ac46cf) into feature/sdkv2 (05aa709) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           feature/sdkv2    #1199      +/-   ##
=================================================
- Coverage          83.38%   83.19%   -0.19%     
=================================================
  Files                356      352       -4     
  Lines              11987    11857     -130     
  Branches            2061     2050      -11     
=================================================
- Hits                9995     9864     -131     
- Misses              1357     1359       +2     
+ Partials             635      634       -1
Impacted Files Coverage Δ
...d/v2/core/internal/storage/FileEventBatchWriter.kt 95.24% <0.00%> (-2.38%) ⬇️
...core/internal/system/DefaultAndroidInfoProvider.kt 83.02% <0.00%> (-1.89%) ⬇️
...lin/com/datadog/android/rum/internal/RumFeature.kt 90.91% <0.00%> (-1.65%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 88.99% <0.00%> (-1.32%) ⬇️
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 88.24% <0.00%> (-0.98%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 94.87% <0.00%> (-0.55%) ⬇️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 86.67% <0.00%> (ø)
...in/com/datadog/android/log/internal/LogsFeature.kt 90.59% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <0.00%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.27% <0.00%> (+0.84%) ⬆️
... and 3 more

@0xnm
0xnm merged commit ca94f5b into feature/sdkv2 Dec 16, 2022
@0xnm
0xnm deleted the nogorodnikov/delete-obsolete-feature-specific-uploaders branch December 16, 2022 06:58
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83