RUMM-2806 Drop the covered wireframes only if top ones have a background#1198
Merged
mariusc83 merged 1 commit intoDec 16, 2022
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-2806/filter-out-wireframes-only-when-top-has-a-background
branch
from
December 15, 2022 16:25
a97e155 to
cc0004b
Compare
mariusc83
marked this pull request as ready for review
December 15, 2022 16:29
xgouchet
reviewed
Dec 15, 2022
| } | ||
| } | ||
|
|
||
| private fun MobileSegment.Wireframe.hasBackground(): Boolean { |
Contributor
There was a problem hiding this comment.
what if the background is transparent?
Member
Author
There was a problem hiding this comment.
Good catch, I am going to filter those out also.
Member
There was a problem hiding this comment.
👍 or semi-transparent. On iOS we recently added isTranslucent for similar use case, which also takes view's alpha (opacity) into account. It doesn't yet check the background color's alpha, but remains extensible in that direction (e.g. a background of #FF000099 should be considered translucent).
Member
Author
There was a problem hiding this comment.
yup I modified it in order to just consider alpha FF in the color and 1f in the ShapeStyle opacity. Any other wireframe with any alpha value will be not considered as overlay.
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1198 +/- ##
=================================================
- Coverage 83.38% 83.36% -0.02%
=================================================
Files 356 356
Lines 11987 11985 -2
Branches 2061 2061
=================================================
- Hits 9995 9991 -4
- Misses 1357 1358 +1
- Partials 635 636 +1
|
mariusc83
force-pushed
the
mconstantin/rumm-2806/filter-out-wireframes-only-when-top-has-a-background
branch
3 times, most recently
from
December 16, 2022 09:21
0dc18c5 to
ae7a05f
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2806/filter-out-wireframes-only-when-top-has-a-background
branch
2 times, most recently
from
December 16, 2022 10:41
a7148b4 to
63123ae
Compare
0xnm
approved these changes
Dec 16, 2022
xgouchet
approved these changes
Dec 16, 2022
| } | ||
| topWireframes.forEach { | ||
| if (it.bounds().isCovering(wireframeBounds)) { | ||
| if (it.bounds().isCovering(wireframeBounds) && it.isNotTranslucent()) { |
Contributor
There was a problem hiding this comment.
Nitpicking here, maybe using isOpaque would avoid having to handle the negation when thinking at the logic
mariusc83
force-pushed
the
mconstantin/rumm-2806/filter-out-wireframes-only-when-top-has-a-background
branch
from
December 16, 2022 13:54
63123ae to
b3f7083
Compare
mariusc83
deleted the
mconstantin/rumm-2806/filter-out-wireframes-only-when-top-has-a-background
branch
December 16, 2022 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before we were filtering out all the overlayed wireframes no matter if the top ones were having a solid background or not. This creates a problem because if the removed wireframe is actual the one that gives the main background in a View we will be loosing the contrast in the replay and will make some elements invisible (e.g. texts).
In order to fix this we are now only considering as valid overlays the wireframes that also have a solid backround.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)