Fix flaky telemetry test#1197
Merged
Merged
Conversation
xgouchet
approved these changes
Dec 15, 2022
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1197 +/- ##
=================================================
- Coverage 83.38% 83.36% -0.02%
=================================================
Files 356 356
Lines 11987 11982 -5
Branches 2061 2059 -2
=================================================
- Hits 9995 9988 -7
- Misses 1357 1358 +1
- Partials 635 636 +1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes fixes flaky
TelemetryEventHandlerTest#𝕄 count the limit only after the sampling 𝕎 handleEvent(SendTelemetry)test.Review checklist (to be filled by reviewers)