Skip to content

Fix flaky rum_rummonitor_add_background_custom_action_with_outcome nightly test#1195

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-flaky-rum_rummonitor_add_background_custom_action_with_outcome-test
Dec 14, 2022
Merged

Fix flaky rum_rummonitor_add_background_custom_action_with_outcome nightly test#1195
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-flaky-rum_rummonitor_add_background_custom_action_with_outcome-test

Conversation

@0xnm

@0xnm 0xnm commented Dec 14, 2022

Copy link
Copy Markdown
Member

What does this PR do?

This test is flaky, because it allowed to generate back action type, which has empty action.name.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 14, 2022 10:23
@codecov-commenter

codecov-commenter commented Dec 14, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1195 (35c2134) into develop (e707d40) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1195   +/-   ##
========================================
  Coverage    82.31%   82.31%           
========================================
  Files          353      353           
  Lines        11795    11790    -5     
  Branches      2007     2005    -2     
========================================
- Hits          9708     9704    -4     
+ Misses        1475     1473    -2     
- Partials       612      613    +1
Impacted Files Coverage Δ
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-2.94%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 95.24% <0.00%> (-2.38%) ⬇️
...android/log/internal/domain/DatadogLogGenerator.kt 94.63% <0.00%> (-1.34%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.21% <0.00%> (-0.99%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 71.43% <0.00%> (-0.84%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 89.86% <0.00%> (-0.46%) ⬇️
...in/com/datadog/android/log/internal/LogsFeature.kt 88.71% <0.00%> (ø)
...android/v2/core/internal/DatadogContextProvider.kt 81.54% <0.00%> (ø)
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.49% <0.00%> (+0.42%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 93.37% <0.00%> (+0.55%) ⬆️
... and 6 more

@0xnm
0xnm merged commit 44d6d0b into develop Dec 14, 2022
@0xnm
0xnm deleted the nogorodnikov/fix-flaky-rum_rummonitor_add_background_custom_action_with_outcome-test branch December 14, 2022 11:00
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83