Skip to content

Update apiSurface#1193

Merged
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/update-api-surface-after-develop-into-sdkv2-merge
Dec 14, 2022
Merged

Update apiSurface#1193
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/update-api-surface-after-develop-into-sdkv2-merge

Conversation

@0xnm

@0xnm 0xnm commented Dec 14, 2022

Copy link
Copy Markdown
Member

What does this PR do?

After the recent merge from develop to feature/sdkv2 branch apiSurface files seems have been overwritten, fixing it by generating the proper ones (otherwise CI builds for feature/sdkv2 fail).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 14, 2022 08:57
@codecov-commenter

codecov-commenter commented Dec 14, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.38%. Comparing base (ac97bb0) to head (0d01461).

Additional details and impacted files
@@                Coverage Diff                @@
##           feature/sdkv2    #1193      +/-   ##
=================================================
+ Coverage          83.30%   83.38%   +0.08%     
=================================================
  Files                356      356              
  Lines              11969    11982      +13     
  Branches            2059     2059              
=================================================
+ Hits                9970     9991      +21     
- Misses              1356     1357       +1     
+ Partials             643      634       -9     

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 044e33f into feature/sdkv2 Dec 14, 2022
@0xnm
0xnm deleted the nogorodnikov/update-api-surface-after-develop-into-sdkv2-merge branch December 14, 2022 09:28
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants