Fix typo in CONTRIBUTING.md#1188
Merged
0xnm merged 1 commit intoDec 13, 2022
Merged
Conversation
xgouchet
reviewed
Dec 12, 2022
Comment on lines
+52
to
+53
| detekt --config {dd-source}/domains/mobile/config/android/gitlab/detekt/detekt-common.yml --excludes "**/model/*.kt,**/build/**" | ||
| detekt --config {dd-source}/domains/mobile/config/android/gitlab/detekt/detekt-public-api.yml --excludes "**/model/*.kt,**/build/**" |
Contributor
There was a problem hiding this comment.
You can use --excludes "**/build/**" as I have a PR moving the generated files into the build folder, and I'm gonna change the shared config to ignore those folders anyway
Contributor
|
This should not be needed after #1189 and ddsource#20537 are merged |
0xnm
force-pushed
the
nogorodnikov/exclude-generated-files-from-detekt-run
branch
from
December 13, 2022 08:22
54c6652 to
111bbde
Compare
0xnm
changed the title
Member
Author
|
@xgouchet good to know! let's keep the part with typo fix then, I updated and renamed this PR. |
xgouchet
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1188 +/- ##
===========================================
+ Coverage 82.27% 82.30% +0.03%
===========================================
Files 353 353
Lines 11793 11793
Branches 2006 2006
===========================================
+ Hits 9702 9706 +4
+ Misses 1477 1476 -1
+ Partials 614 611 -3
|
mariusc83
approved these changes
Dec 13, 2022
0xnm
deleted the
nogorodnikov/exclude-generated-files-from-detekt-run
branch
December 13, 2022 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fixes a typo in
CONTRIBUTING.mdfile.Review checklist (to be filled by reviewers)