Skip to content

RUMM-2783 Provide SR touch data following the new proposed format#1187

Merged
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/rumm-2783/support-new-sr-touch-interaction-data-format
Dec 12, 2022
Merged

RUMM-2783 Provide SR touch data following the new proposed format#1187
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/rumm-2783/support-new-sr-touch-interaction-data-format

Conversation

@mariusc83

@mariusc83 mariusc83 commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

As a follow up task on the approved RFC we will be sending each touch event as a single PointerInteractionData in a MobileIncrementalSnapshotRecord. This will allow the player to treat the touch events related records as any other record and not have to do extra operations to flatten the TouchData#positions in multiple records as before.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Dec 12, 2022
@codecov-commenter

codecov-commenter commented Dec 12, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1187 (4e31914) into feature/sdkv2 (fb6de14) will increase coverage by 0.04%.
The diff coverage is 88.00%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1187      +/-   ##
=================================================
+ Coverage          83.28%   83.32%   +0.04%     
=================================================
  Files                356      356              
  Lines              11971    11969       -2     
  Branches            2059     2059              
=================================================
+ Hits                9970     9973       +3     
- Misses              1357     1359       +2     
+ Partials             644      637       -7
Impacted Files Coverage Δ
...tadog/android/sessionreplay/processor/Processor.kt 0.00% <0.00%> (ø)
...d/sessionreplay/processor/RecordedDataProcessor.kt 93.48% <83.33%> (ø)
...d/sessionreplay/recorder/RecorderWindowCallback.kt 89.29% <93.75%> (+0.19%) ⬆️
...id/sessionreplay/SessionReplayLifecycleCallback.kt 93.75% <100.00%> (ø)
...d/sessionreplay/recorder/RecorderOnDrawListener.kt 85.71% <100.00%> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-1.96%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 71.67% <0.00%> (-1.67%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.22% <0.00%> (-0.56%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 89.87% <0.00%> (-0.44%) ⬇️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 86.67% <0.00%> (ø)
... and 8 more

@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2783/support-new-sr-touch-interaction-data-format branch 2 times, most recently from 179a31e to 21d06e9 Compare December 12, 2022 10:28
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2767/handle-sr-requests-from-requests-factory branch 3 times, most recently from 0549eb2 to 347b709 Compare December 12, 2022 11:45
Base automatically changed from mconstantin/rumm-2767/handle-sr-requests-from-requests-factory to feature/sdkv2 December 12, 2022 12:10
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2783/support-new-sr-touch-interaction-data-format branch from 21d06e9 to 4e31914 Compare December 12, 2022 12:12
@mariusc83
mariusc83 marked this pull request as ready for review December 12, 2022 12:55
@mariusc83
mariusc83 requested a review from a team as a code owner December 12, 2022 12:55
@mariusc83
mariusc83 merged commit ac97bb0 into feature/sdkv2 Dec 12, 2022
@mariusc83
mariusc83 deleted the mconstantin/rumm-2783/support-new-sr-touch-interaction-data-format branch December 12, 2022 14:34
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

@mariusc83 mariusc83

Labels

None yet

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mariusc83 @codecov-commenter @0xnm @xgouchet