Improve batch upload wait timeout handling#1182
Merged
0xnm merged 1 commit intoDec 9, 2022
Merged
Conversation
xgouchet
approved these changes
Dec 9, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1182 +/- ##
===========================================
+ Coverage 82.25% 82.28% +0.03%
===========================================
Files 353 353
Lines 11777 11780 +3
Branches 2005 2006 +1
===========================================
+ Hits 9686 9692 +6
- Misses 1474 1475 +1
+ Partials 617 613 -4
|
mariusc83
approved these changes
Dec 9, 2022
0xnm
deleted the
nogorodnikov/improve-batch-wait-timeout-handling-for-the-batch-upload
branch
December 9, 2022 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change improves lock handling scenario in the batch upload. Before, if any exception would happen during the batch upload if
Storage#readNextBatchis async (which is not the case right now), lock would be removed only after timeout. Now lock is removed immediately.This is mostly a safeguard if at any point
Storage#readNextBatchbecomes async, but we probably need to revert the switch to async-like API in the upload pipeline back to the blocking API, because async one doesn't really bring any benefit and actually makes code more complex.Review checklist (to be filled by reviewers)