RUMM-2755: Remove site property from DatadogContext#1181
Merged
0xnm merged 1 commit intoDec 9, 2022
Conversation
xgouchet
approved these changes
Dec 9, 2022
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1181 +/- ##
=================================================
+ Coverage 82.09% 82.12% +0.03%
=================================================
Files 355 355
Lines 11973 11970 -3
Branches 2049 2049
=================================================
+ Hits 9829 9830 +1
+ Misses 1506 1505 -1
+ Partials 638 635 -3
|
mariusc83
approved these changes
Dec 9, 2022
0xnm
deleted the
nogorodnikov/rumm-2755/remove-site-from-datadog-context
branch
December 9, 2022 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
siteproperty is not used neither in the write, nor in the upload flows by the features, so removing it fromDatadogContext. Also it is not possible to have it when custom URLs are used anyway.Review checklist (to be filled by reviewers)