Skip to content

MTG-8 Apply new detekt configuration#1180

Merged
xgouchet merged 15 commits into
developfrom
xgouchet/MTG-8/detekt
Dec 12, 2022
Merged

MTG-8 Apply new detekt configuration#1180
xgouchet merged 15 commits into
developfrom
xgouchet/MTG-8/detekt

Conversation

@xgouchet

@xgouchet xgouchet commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Use the shared static analysis job with an updated detekt configuration

@xgouchet
xgouchet requested a review from a team as a code owner December 8, 2022 15:18
@xgouchet
xgouchet force-pushed the xgouchet/MTG-8/detekt branch from 88723c4 to 7703c30 Compare December 8, 2022 16:02
@codecov-commenter

codecov-commenter commented Dec 8, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1180 (32a07a0) into develop (67e6ba4) will decrease coverage by 0.04%.
The diff coverage is 87.27%.

❗ Current head 32a07a0 differs from pull request most recent head be1bce6. Consider uploading reports for the commit be1bce6 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1180      +/-   ##
===========================================
- Coverage    82.31%   82.26%   -0.04%     
===========================================
  Files          353      353              
  Lines        11778    11790      +12     
  Branches      2006     2005       -1     
===========================================
+ Hits          9694     9699       +5     
- Misses        1470     1475       +5     
- Partials       614      616       +2
Impacted Files Coverage Δ
.../com/datadog/android/ktx/coroutine/CoroutineExt.kt 75.86% <ø> (ø)
.../kotlin/com/datadog/android/ktx/rum/ClosableExt.kt 100.00% <ø> (ø)
...om/datadog/android/ktx/sqlite/SqliteDatabaseExt.kt 92.86% <ø> (ø)
.../kotlin/com/datadog/android/ktx/tracing/SpanExt.kt 86.67% <ø> (-1.57%) ⬇️
...in/com/datadog/android/sqldelight/SqlDelightExt.kt 80.65% <ø> (ø)
...rnal/persistence/file/EncryptedFileReaderWriter.kt 93.75% <ø> (ø)
...ndroid/core/internal/persistence/file/FileMover.kt 62.96% <ø> (ø)
...rnal/persistence/file/batch/BatchFileDataWriter.kt 88.24% <ø> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 88.24% <ø> (+1.96%) ⬆️
...al/persistence/file/single/SingleItemDataWriter.kt 95.83% <ø> (ø)
... and 76 more

mariusc83
mariusc83 requested changes Dec 9, 2022
View reviewed changes
Comment thread buildSrc/src/test/kotlin/com/example/model/Version.kt Outdated
Comment thread library/dd-sdk-android-session-replay/clone_session_replay_schema.gradle.kts Outdated
Comment thread library/dd-sdk-android-session-replay/clone_session_replay_schema.gradle.kts Outdated
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md Outdated
0xnm
0xnm reviewed Dec 9, 2022
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread dd-sdk-android/src/main/kotlin/com/datadog/android/DatadogInterceptor.kt Outdated
Comment thread .../main/kotlin/com/datadog/android/core/internal/persistence/file/batch/BatchFileDataWriter.kt Outdated
Comment thread ...kotlin/com/datadog/android/core/internal/persistence/file/batch/BatchFileOrchestratorTest.kt Outdated
Comment thread gradle/libs.versions.toml
Comment thread instrumented/nightly-tests/src/main/kotlin/com/datadog/android/nightly/activities/Constants.kt Outdated
Comment thread tools/detekt/src/main/kotlin/com/datadog/tools/detekt/rules/InvalidStringFormat.kt
Comment thread tools/unit/src/main/kotlin/com/datadog/tools/unit/ConditionWatcher.kt Outdated
@xgouchet
xgouchet requested review from 0xnm and mariusc83 December 9, 2022 10:57
0xnm
0xnm approved these changes Dec 9, 2022
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xgouchet
xgouchet force-pushed the xgouchet/MTG-8/detekt branch from 10deac9 to 3d1c451 Compare December 12, 2022 13:38
@xgouchet
xgouchet force-pushed the xgouchet/MTG-8/detekt branch from 3d1c451 to be1bce6 Compare December 12, 2022 14:07
@xgouchet
xgouchet merged commit 2dffc83 into develop Dec 12, 2022
@xgouchet
xgouchet deleted the xgouchet/MTG-8/detekt branch December 12, 2022 15:02
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@xgouchet @codecov-commenter @mariusc83 @0xnm