RUMM-2789: Use message bus to report NDK crashes to RUM#1177
Merged
0xnm merged 1 commit intoDec 8, 2022
Merged
Conversation
0xnm
marked this pull request as ready for review
December 7, 2022 13:31
0xnm
force-pushed
the
nogorodnikov/rumm-2789/use-message-bus-for-ndk-crash-reporting-to-rum
branch
from
December 8, 2022 10:07
85f25e7 to
57a9b74
Compare
mariusc83
reviewed
Dec 8, 2022
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1177 +/- ##
=================================================
- Coverage 82.17% 82.15% -0.02%
=================================================
Files 352 355 +3
Lines 11929 11973 +44
Branches 2042 2049 +7
=================================================
+ Hits 9802 9836 +34
- Misses 1502 1503 +1
- Partials 625 634 +9
|
0xnm
force-pushed
the
nogorodnikov/rumm-2789/use-message-bus-for-ndk-crash-reporting-to-rum
branch
from
December 8, 2022 10:44
57a9b74 to
1a7d32c
Compare
mariusc83
approved these changes
Dec 8, 2022
xgouchet
approved these changes
Dec 8, 2022
0xnm
deleted the
nogorodnikov/rumm-2789/use-message-bus-for-ndk-crash-reporting-to-rum
branch
December 8, 2022 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the way NDK crashes are reported to RUM: now they will be sent through the message bus, because RUM feature may be optional and will reside in another module anyway.
Also there are now 2 different message types for the crashes coming to Logs and RUM:
jvm_crashandndk_crash. This way the code is simpler and is easier to test.DatadogNdkCrashHandlernow reads last view event as JSON (because RUM-specific deserializers won't be available), takes view ID, session ID and application ID from it and passes it to the RUM feature where further deserialization fromJsonObjectto the RUM-specific type is done.Review checklist (to be filled by reviewers)