Skip to content

Update telemetry configuration schema#1175

Merged
louiszawadzki merged 1 commit into
developfrom
louiszawadzki/rumm-2631/update-rum-events-format
Dec 7, 2022
Merged

Update telemetry configuration schema#1175
louiszawadzki merged 1 commit into
developfrom
louiszawadzki/rumm-2631/update-rum-events-format

Conversation

@louiszawadzki

@louiszawadzki louiszawadzki commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Update telemetry configuration schema.

Motivation

This allows cross-platform SDKs to update more fields in the configuration.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@louiszawadzki
louiszawadzki requested a review from a team as a code owner December 6, 2022 17:11
@codecov-commenter

codecov-commenter commented Dec 7, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1175 (f8994d3) into develop (b4ea30b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1175      +/-   ##
===========================================
- Coverage    82.24%   82.21%   -0.03%     
===========================================
  Files          353      353              
  Lines        11775    11775              
  Branches      2005     2005              
===========================================
- Hits          9684     9680       -4     
  Misses        1475     1475              
- Partials       616      620       +4
Impacted Files Coverage Δ
...android/log/internal/logger/TelemetryLogHandler.kt 85.71% <0.00%> (-14.29%) ⬇️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 80.77% <0.00%> (-3.85%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 85.71% <0.00%> (-1.48%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 57.76% <0.00%> (-0.86%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 71.67% <0.00%> (-0.83%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 89.40% <0.00%> (ø)
...in/com/datadog/android/log/internal/LogsFeature.kt 87.10% <0.00%> (ø)
...android/v2/core/internal/DatadogContextProvider.kt 81.54% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <0.00%> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 95.42% <0.00%> (+0.18%) ⬆️
... and 2 more

@louiszawadzki
louiszawadzki merged commit 6c6af82 into develop Dec 7, 2022
@louiszawadzki
louiszawadzki deleted the louiszawadzki/rumm-2631/update-rum-events-format branch December 7, 2022 09:54
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@louiszawadzki @codecov-commenter @xgouchet @mariusc83 @0xnm