Skip to content

RUMM-2787: Use message bus to report Java crashes to RUM#1173

Merged
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2787/use-message-bus-for-java-crashes-reporting-to-rum
Dec 7, 2022
Merged

RUMM-2787: Use message bus to report Java crashes to RUM#1173
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2787/use-message-bus-for-java-crashes-reporting-to-rum

Conversation

@0xnm

@0xnm 0xnm commented Dec 6, 2022

Copy link
Copy Markdown
Member

What does this PR do?

This changes makes Java crash reporting use message bus to forward crash to RUM (as RUM error).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 6, 2022 10:28
@codecov-commenter

codecov-commenter commented Dec 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1173 (94f8d98) into nogorodnikov/rumm-2781/remove-duplication-of-userinfo-and-networkinfo-classes (80f504b) will increase coverage by 0.00%.
The diff coverage is 91.18%.

@@                                              Coverage Diff                                               @@
##           nogorodnikov/rumm-2781/remove-duplication-of-userinfo-and-networkinfo-classes    #1173   +/-   ##
==============================================================================================================
  Coverage                                                                          82.17%   82.17%           
==============================================================================================================
  Files                                                                                352      352           
  Lines                                                                              11898    11927   +29     
  Branches                                                                            2033     2042    +9     
==============================================================================================================
+ Hits                                                                                9777     9801   +24     
- Misses                                                                              1499     1503    +4     
- Partials                                                                             622      623    +1     
Impacted Files Coverage Δ
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.06% <87.50%> (-1.07%) ⬇️
.../android/error/internal/DatadogExceptionHandler.kt 90.48% <100.00%> (+9.40%) ⬆️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 76.92% <0.00%> (-3.85%) ⬇️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 83.33% <0.00%> (-3.33%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (-1.72%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.70% <0.00%> (-0.49%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.07% <0.00%> (-0.42%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.05% <0.00%> (-0.37%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 93.33% <0.00%> (+0.56%) ⬆️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.50% <0.00%> (+0.83%) ⬆️
... and 2 more

Base automatically changed from nogorodnikov/rumm-2781/remove-duplication-of-userinfo-and-networkinfo-classes to feature/sdkv2 December 7, 2022 08:41
@0xnm
0xnm merged commit ebf706c into feature/sdkv2 Dec 7, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-2787/use-message-bus-for-java-crashes-reporting-to-rum branch December 7, 2022 09:03
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants