Skip to content

Cherry-pick: Make a local copy of tags before creating LogEvent#1172

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/cherry-pick-make-local-copy-of-tags-for-logs
Dec 6, 2022
Merged

Cherry-pick: Make a local copy of tags before creating LogEvent#1172
0xnm merged 1 commit into
developfrom
nogorodnikov/cherry-pick-make-local-copy-of-tags-for-logs

Conversation

@0xnm

@0xnm 0xnm commented Dec 5, 2022

Copy link
Copy Markdown
Member

What does this PR do?

Cherry-pick of #1171 for the develop branch.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 5, 2022 18:24
@codecov-commenter

codecov-commenter commented Dec 5, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.29%. Comparing base (b4ea30b) to head (2f8e703).
⚠️ Report is 3558 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1172      +/-   ##
===========================================
+ Coverage    82.24%   82.29%   +0.05%     
===========================================
  Files          353      353              
  Lines        11775    11777       +2     
  Branches      2005     2005              
===========================================
+ Hits          9684     9691       +7     
+ Misses        1475     1472       -3     
+ Partials       616      614       -2     
Files with missing lines Coverage Δ
.../src/main/kotlin/com/datadog/android/log/Logger.kt 97.06% <100.00%> (+0.79%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm
0xnm merged commit 84835ea into develop Dec 6, 2022
@0xnm
0xnm deleted the nogorodnikov/cherry-pick-make-local-copy-of-tags-for-logs branch December 6, 2022 17:12
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants