Make a local copy of tags before creating LogEvent#1171
Merged
fuzzybinary merged 1 commit intoDec 5, 2022
Merged
Conversation
fuzzybinary
requested changes
Dec 5, 2022
0xnm
force-pushed
the
nogorodnikov/make-local-copy-of-tags-before-log-event-creation
branch
from
December 5, 2022 15:33
83da17f to
a89af10
Compare
0xnm
force-pushed
the
nogorodnikov/make-local-copy-of-tags-before-log-event-creation
branch
from
December 5, 2022 15:42
a89af10 to
2fc99ec
Compare
fuzzybinary
approved these changes
Dec 5, 2022
fuzzybinary
deleted the
nogorodnikov/make-local-copy-of-tags-before-log-event-creation
branch
December 5, 2022 17:04
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We need to make a copy of
tags, because by the time we createLogEvent(on the worker thread) it may have been changed by another thread.Review checklist (to be filled by reviewers)