RUMM-2781: Remove duplication of UserInfo and NetworkInfo classes#1170
Merged
0xnm merged 1 commit intoDec 7, 2022
Conversation
xgouchet
approved these changes
Dec 5, 2022
mariusc83
approved these changes
Dec 7, 2022
0xnm
deleted the
nogorodnikov/rumm-2781/remove-duplication-of-userinfo-and-networkinfo-classes
branch
December 7, 2022 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change removes core models
UserInfoandNetworkInfoin order to rely completely to the similar models fromcom.datadog.android.v2.api.contextpackage in all the flows: SDK content retrieval, log generation, NDK crash handling, etc.Serialization and de-serialization for
UserInfoandNetworkInfomodels are not auto-generated as for the models fromcorepackage, because there is no need to expose related methods to the public API (they are completely fine to beinternal, because serialization and de-serialization is done only from the main module), and classes are not auto-generated as well, for the consistency with other classes fromcom.datadog.android.v2.api.contextpackage.Also some classes are moved out from
logpackage to thecorepackage, because they have nothing to do with Logs flow.Review checklist (to be filled by reviewers)