Skip to content

RUMM-2781: Remove duplication of UserInfo and NetworkInfo classes#1170

Merged
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2781/remove-duplication-of-userinfo-and-networkinfo-classes
Dec 7, 2022
Merged

RUMM-2781: Remove duplication of UserInfo and NetworkInfo classes#1170
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2781/remove-duplication-of-userinfo-and-networkinfo-classes

Conversation

@0xnm

@0xnm 0xnm commented Dec 5, 2022

Copy link
Copy Markdown
Member

What does this PR do?

This change removes core models UserInfo and NetworkInfo in order to rely completely to the similar models from com.datadog.android.v2.api.context package in all the flows: SDK content retrieval, log generation, NDK crash handling, etc.

Serialization and de-serialization for UserInfo and NetworkInfo models are not auto-generated as for the models from core package, because there is no need to expose related methods to the public API (they are completely fine to be internal, because serialization and de-serialization is done only from the main module), and classes are not auto-generated as well, for the consistency with other classes from com.datadog.android.v2.api.context package.

Also some classes are moved out from log package to the core package, because they have nothing to do with Logs flow.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner December 5, 2022 11:05
@0xnm
0xnm merged commit 339785f into feature/sdkv2 Dec 7, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-2781/remove-duplication-of-userinfo-and-networkinfo-classes branch December 7, 2022 08:41
@xgouchet xgouchet added this to the 1.17.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants