Fix some nightly tests flakiness#1165
Merged
Merged
Conversation
mariusc83
approved these changes
Nov 29, 2022
xgouchet
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fixes some flakiness in our tests:
action.nameassertion, but in case ofaction.type=backthere is noaction.name, onlyaction.target.name. So we need to excludebackaction type from such tests.browser-sdkrequires an element to havepointerdownevent before the actual click to register RUM action. The change is done instrumented test to add the necessary event.Review checklist (to be filled by reviewers)