RUMM-2769 Fix NPE in ScreenRecorder when wrapping a null window.callback#1164
Merged
mariusc83 merged 1 commit intoNov 29, 2022
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-2769/fix-npe-in-sr-screen-recorder
branch
from
November 29, 2022 13:14
1df9a55 to
bbd794f
Compare
mariusc83
marked this pull request as ready for review
November 29, 2022 13:16
0xnm
approved these changes
Nov 29, 2022
| testedRecorder.startRecording(mockActivity) | ||
|
|
||
| // Then | ||
| val captor = argumentCaptor<Window.Callback>() |
Member
There was a problem hiding this comment.
minor: we can use lambda syntax with captor == this
argumentCaptor<Window.Callback>() {
...
}
Member
Author
There was a problem hiding this comment.
I find it a bit unreadable for me that way :). That's the reason I prefer to non-lambda way.
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1164 +/- ##
=================================================
- Coverage 82.33% 82.25% -0.09%
=================================================
Files 352 353 +1
Lines 11813 11839 +26
Branches 2012 2015 +3
=================================================
+ Hits 9726 9737 +11
- Misses 1461 1481 +20
+ Partials 626 621 -5
|
mariusc83
deleted the
mconstantin/rumm-2769/fix-npe-in-sr-screen-recorder
branch
November 29, 2022 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)