Skip to content

Nightly tests improvements#1163

Merged
0xnm merged 4 commits into
developfrom
nogorodnikov/nightly-tests-improvements
Nov 29, 2022
Merged

Nightly tests improvements#1163
0xnm merged 4 commits into
developfrom
nogorodnikov/nightly-tests-improvements

Conversation

@0xnm

@0xnm 0xnm commented Nov 28, 2022

Copy link
Copy Markdown
Member

What does this PR do?

Some improvements for the nightly tests run:

  • Don't attempt to read metadata if meta file doesn't exist (doesn't impact the functionality, just removes some error noise).
  • Update Android X test libraries for the better compatibility with API 33.
  • Replace source.unsplash.com with picsum.photos, because the former is not reliable anymore (it was deprecated one year ago and is currently down for few days already).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner November 28, 2022 11:05
@0xnm
0xnm force-pushed the nogorodnikov/nightly-tests-improvements branch from d75d1fb to a49d3a1 Compare November 28, 2022 11:30
@xgouchet xgouchet added the size-small This PR is small sized label Nov 28, 2022
@0xnm
0xnm merged commit 9eb9417 into develop Nov 29, 2022
@0xnm
0xnm deleted the nogorodnikov/nightly-tests-improvements branch November 29, 2022 07:53
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-small This PR is small sized size-tiny

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants