Skip to content

RUMM-2298 Correctly resolve ShapeStyle opacity in Wireframes#1152

Merged
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/rumm-2298/correctly-resolve-the-wireframe-opacity
Nov 23, 2022
Merged

RUMM-2298 Correctly resolve ShapeStyle opacity in Wireframes#1152
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/rumm-2298/correctly-resolve-the-wireframe-opacity

Conversation

@mariusc83

@mariusc83 mariusc83 commented Nov 22, 2022

Copy link
Copy Markdown
Member

What does this PR do?

Previously we were resolving the ShapeStyle opacity from the View.backround which is not correct. For example a TextView can use a transparent background but still have a visible content. We need to resolve this attribute directly from the View.alpha property.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Nov 22, 2022
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2298/correctly-resolve-the-wireframe-opacity branch from de24152 to 9741566 Compare November 22, 2022 14:38
@mariusc83
mariusc83 marked this pull request as ready for review November 22, 2022 14:38
@mariusc83
mariusc83 requested a review from a team as a code owner November 22, 2022 14:38
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2298/correctly-resolve-the-wireframe-opacity branch from 9741566 to 0d80a42 Compare November 22, 2022 16:10
@codecov-commenter

codecov-commenter commented Nov 22, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1152 (0d80a42) into feature/sdkv2 (76701ae) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1152      +/-   ##
=================================================
- Coverage          82.38%   82.36%   -0.03%     
=================================================
  Files                352      352              
  Lines              11756    11756              
  Branches            2006     2006              
=================================================
- Hits                9685     9682       -3     
+ Misses              1451     1450       -1     
- Partials             620      624       +4
Impacted Files Coverage Δ
...ssionreplay/recorder/mapper/ViewWireframeMapper.kt 88.46% <75.00%> (ø)
...in/com/datadog/android/log/internal/LogsFeature.kt 87.10% <0.00%> (-4.84%) ⬇️
...d/v2/core/internal/storage/FileEventBatchWriter.kt 95.24% <0.00%> (-2.38%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.78% <0.00%> (-0.56%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 88.58% <0.00%> (-0.46%) ⬇️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 86.67% <0.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 86.70% <0.00%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.50% <0.00%> (ø)
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (+0.86%) ⬆️
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 88.24% <0.00%> (+1.96%) ⬆️

@mariusc83
mariusc83 merged commit 8f78e5f into feature/sdkv2 Nov 23, 2022
@mariusc83
mariusc83 deleted the mconstantin/rumm-2298/correctly-resolve-the-wireframe-opacity branch November 23, 2022 09:41
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

@mariusc83 mariusc83

Labels

size-tiny

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mariusc83 @codecov-commenter @0xnm @xgouchet