Skip to content

Fix flakiness in DebouncerTest class#1151

Merged
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/fix-sr-fix-sr-debouncer-tests-flakiness
Nov 22, 2022
Merged

Fix flakiness in DebouncerTest class#1151
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/fix-sr-fix-sr-debouncer-tests-flakiness

Conversation

@mariusc83

@mariusc83 mariusc83 commented Nov 21, 2022

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Nov 21, 2022
@mariusc83
mariusc83 force-pushed the mconstantin/fix-sr-fix-sr-debouncer-tests-flakiness branch 2 times, most recently from 6e6441d to fe1296a Compare November 21, 2022 14:35
@mariusc83
mariusc83 marked this pull request as ready for review November 21, 2022 14:49
@mariusc83
mariusc83 requested a review from a team as a code owner November 21, 2022 14:49
@mariusc83
mariusc83 force-pushed the mconstantin/fix-sr-fix-sr-debouncer-tests-flakiness branch 2 times, most recently from ac91b77 to dae6c6c Compare November 22, 2022 09:15
@codecov-commenter

codecov-commenter commented Nov 22, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1151 (a91ad78) into feature/sdkv2 (07c6fe9) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1151      +/-   ##
=================================================
- Coverage          82.38%   82.37%   -0.00%     
=================================================
  Files                350      352       +2     
  Lines              11559    11756     +197     
  Branches            1980     2006      +26     
=================================================
+ Hits                9522     9684     +162     
- Misses              1423     1452      +29     
- Partials             614      620       +6
Impacted Files Coverage Δ
...droid/log/internal/logger/ConditionalLogHandler.kt 33.33% <0.00%> (-66.67%) ⬇️
...og/android/log/internal/logger/LogcatLogHandler.kt 64.15% <0.00%> (-13.12%) ⬇️
.../main/kotlin/com/datadog/android/rum/RumMonitor.kt 77.08% <ø> (ø)
...atadog/android/log/internal/domain/LogGenerator.kt 60.00% <40.00%> (-20.00%) ⬇️
...datadog/android/core/internal/utils/UserInfoExt.kt 50.00% <50.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.19% <63.64%> (-0.12%) ⬇️
.../datadog/android/log/internal/logger/LogHandler.kt 77.78% <75.00%> (-2.22%) ⬇️
...roid/rum/internal/domain/scope/RumResourceScope.kt 95.24% <78.95%> (-1.79%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.42% <83.67%> (-0.95%) ⬇️
...g/android/log/internal/logger/DatadogLogHandler.kt 87.95% <84.62%> (-2.96%) ⬇️
... and 31 more

@mariusc83
mariusc83 force-pushed the mconstantin/fix-sr-fix-sr-debouncer-tests-flakiness branch from dae6c6c to a91ad78 Compare November 22, 2022 09:31
@mariusc83
mariusc83 merged commit 76701ae into feature/sdkv2 Nov 22, 2022
@mariusc83
mariusc83 deleted the mconstantin/fix-sr-fix-sr-debouncer-tests-flakiness branch November 22, 2022 09:49
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

@mariusc83 mariusc83

Labels

size-tiny

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mariusc83 @codecov-commenter @0xnm @xgouchet