RUMM-2746 Sync SR touch and screen recorders#1150
Merged
mariusc83 merged 1 commit intoNov 21, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1150 +/- ##
=================================================
+ Coverage 82.38% 82.50% +0.13%
=================================================
Files 350 351 +1
Lines 11559 11573 +14
Branches 1980 1983 +3
=================================================
+ Hits 9522 9548 +26
+ Misses 1423 1422 -1
+ Partials 614 603 -11
|
mariusc83
marked this pull request as ready for review
November 18, 2022 16:10
0xnm
reviewed
Nov 21, 2022
| ) : ViewTreeObserver.OnDrawListener { | ||
| private var currentOrientation = Configuration.ORIENTATION_UNDEFINED | ||
| private val trackedActivity: WeakReference<Activity> = WeakReference(activity) | ||
| private var lastScreenUpdateInNs = System.nanoTime() |
Member
There was a problem hiding this comment.
seems like this field is not used: it is written, but never read.
| forge: Forge | ||
| ) { | ||
| // Given | ||
| val fakeDelayedRunnables = forge.aList(size = forge.anInt(min = 0, max = 10)) { TestRunnable() } |
Member
There was a problem hiding this comment.
having min=0 will make it possible to have empty fakeDelayedRunnables list, leading to the division by zero on the line below. Same for the test below.
Member
Author
There was a problem hiding this comment.
oh damn...yes, I actually had min=1 there at some point I don't know why I changed it back. Nicely spotted.
mariusc83
force-pushed
the
mconstantin/rumm-2746/sync-sr-touch-and-screen-recorders
branch
2 times, most recently
from
November 21, 2022 09:48
df93304 to
3bb3bbd
Compare
0xnm
approved these changes
Nov 21, 2022
| } | ||
|
|
||
| companion object { | ||
| private val TEST_MAX_DELAY_THRESHOLD_IN_NS = TimeUnit.SECONDS.toNanos(2) |
Member
There was a problem hiding this comment.
minor: this probably can be even lower to make tests faster
Member
Author
There was a problem hiding this comment.
yup...I hesitated as not to have longer tests, we already have quite a lot but I guess is better than to have flaky ones.
mariusc83
force-pushed
the
mconstantin/rumm-2746/sync-sr-touch-and-screen-recorders
branch
from
November 21, 2022 10:44
3bb3bbd to
7980e9d
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2746/sync-sr-touch-and-screen-recorders
branch
from
November 21, 2022 10:52
7980e9d to
c23b880
Compare
xgouchet
approved these changes
Nov 21, 2022
mariusc83
deleted the
mconstantin/rumm-2746/sync-sr-touch-and-screen-recorders
branch
November 21, 2022 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)