Skip to content

Remove non-existent function in dogfood script#1136

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/fix_dogfood_script
Nov 9, 2022
Merged

Remove non-existent function in dogfood script#1136
0xnm merged 1 commit into
developfrom
nogorodnikov/fix_dogfood_script

Conversation

@0xnm

@0xnm 0xnm commented Nov 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Follow-up for #1120: remove the usage of the function which was deleted. Otherwise it breaks all the dogfood updates with exception like this:

Traceback (most recent call last):
  File "dogfood.py", line 160, in <module>
    sys.exit(run_main())
  File "dogfood.py", line 156, in run_main
    return update_dependant(cli_args.version, cli_args.target, gh_token, cli_args.dry_run)
  File "dogfood.py", line 135, in update_dependant
    update_version_table(target, temp_dir_path, version)
NameError: name 'update_version_table' is not defined

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner November 9, 2022 09:03
@codecov-commenter

codecov-commenter commented Nov 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1136 (ce8a232) into develop (9753f83) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1136      +/-   ##
===========================================
+ Coverage    83.17%   83.20%   +0.02%     
===========================================
  Files          274      274              
  Lines         9462     9462              
  Branches      1540     1540              
===========================================
+ Hits          7870     7872       +2     
  Misses        1152     1152              
+ Partials       440      438       -2
Impacted Files Coverage Δ
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.32% <0.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.65% <0.00%> (+1.08%) ⬆️

@0xnm
0xnm merged commit 181e350 into develop Nov 9, 2022
@0xnm
0xnm deleted the nogorodnikov/fix_dogfood_script branch November 9, 2022 10:05
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-tiny

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @xgouchet