Skip to content

Filter out telemetry in the assertions of instrumented RUM tests#1131

Merged
xgouchet merged 1 commit into
developfrom
nogorodnikov/filter-out-telemetry-in-instrumented-rum-tests-assertions
Nov 8, 2022
Merged

Filter out telemetry in the assertions of instrumented RUM tests#1131
xgouchet merged 1 commit into
developfrom
nogorodnikov/filter-out-telemetry-in-instrumented-rum-tests-assertions

Conversation

@0xnm

@0xnm 0xnm commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Follow-up for #1118: now we have configuration telemetry event sent with the delay, which makes RUM instrumented tests flaky, because configuration telemetry event may or may not be in the intercepted RUM requests.

This changes filters out telemetry events from the list of RUM events against which the assertion will be done.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner November 8, 2022 11:00
plousada
plousada approved these changes Nov 8, 2022
View reviewed changes

@plousada plousada left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming it's ok to filter out all telemetry events (debug and error inc) even when we weren't doing it before.

@codecov-commenter

codecov-commenter commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1131 (0ff377e) into develop (c54a0ba) will decrease coverage by 0.12%.
The diff coverage is 69.91%.

@@             Coverage Diff             @@
##           develop    #1131      +/-   ##
===========================================
- Coverage    83.26%   83.14%   -0.12%     
===========================================
  Files          273      274       +1     
  Lines         9372     9459      +87     
  Branches      1504     1539      +35     
===========================================
+ Hits          7803     7864      +61     
- Misses        1150     1155       +5     
- Partials       419      440      +21
Impacted Files Coverage Δ
...ndroid/telemetry/internal/TelemetryEventHandler.kt 72.32% <55.36%> (-19.74%) ⬇️
...oid/src/main/kotlin/com/datadog/android/Datadog.kt 81.95% <60.87%> (-0.01%) ⬇️
...n/kotlin/com/datadog/android/DatadogInterceptor.kt 87.50% <100.00%> (+0.29%) ⬆️
...atadog/android/core/configuration/Configuration.kt 98.76% <100.00%> (+1.26%) ⬆️
...c/main/kotlin/com/datadog/android/rum/GlobalRum.kt 70.27% <100.00%> (+0.83%) ⬆️
...ndroid/rum/internal/domain/event/RumEventMapper.kt 94.23% <100.00%> (+0.23%) ⬆️
...id/rum/internal/domain/event/RumEventSerializer.kt 99.09% <100.00%> (+0.02%) ⬆️
...um/internal/domain/event/RumEventSourceProvider.kt 100.00% <100.00%> (ø)
...g/android/rum/internal/domain/scope/RumRawEvent.kt 82.58% <100.00%> (+0.11%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.22% <100.00%> (+0.18%) ⬆️
... and 8 more

@xgouchet
xgouchet merged commit ea20acd into develop Nov 8, 2022
@xgouchet
xgouchet deleted the nogorodnikov/filter-out-telemetry-in-instrumented-rum-tests-assertions branch November 8, 2022 13:09
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plousada plousada plousada approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-tiny

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @plousada