Skip to content

RUMM-2476: Target Android 13#1130

Merged
0xnm merged 2 commits into
developfrom
nogorodnikov/rumm-2476/target-android-13
Nov 8, 2022
Merged

RUMM-2476: Target Android 13#1130
0xnm merged 2 commits into
developfrom
nogorodnikov/rumm-2476/target-android-13

Conversation

@0xnm

@0xnm 0xnm commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This change adds support of Android 13 by doing the following:

  • Build tooling and target API are now set to API 33.
  • API changes are addressed.
  • Docker image is updated to use build tooling for API 33.

Important points:

  • BaseBundle#get type-agnostic call is deprecated, but there is no replacement. https://issuetracker.google.com/issues/243119654 is opened to track this (we are not alone here).
  • NDK version was bumped to v25 (changelog is here, it still supports KitKat, so it is fine to do the version bump)
  • Legacy Cmake was removed from the docker image, because by some reason it is not shown in the list of the available packages for the latest version of sdkmanager for Linux (when I download latest cmdline-tools for Mac, Cmake 3.10 is there by some reason). Anyway, I think it is fine to get rid of it, because unlikely we will have a need to build older SDK releases in our CI.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner November 8, 2022 09:51
@codecov-commenter

codecov-commenter commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1130 (57fe231) into develop (c54a0ba) will decrease coverage by 0.04%.
The diff coverage is 72.13%.

❗ Current head 57fe231 differs from pull request most recent head caecde5. Consider uploading reports for the commit caecde5 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1130      +/-   ##
===========================================
- Coverage    83.26%   83.22%   -0.04%     
===========================================
  Files          273      274       +1     
  Lines         9372     9462      +90     
  Branches      1504     1540      +36     
===========================================
+ Hits          7803     7874      +71     
- Misses        1150     1153       +3     
- Partials       419      435      +16
Impacted Files Coverage Δ
...n/kotlin/com/datadog/android/compose/Navigation.kt 60.98% <ø> (ø)
.../rum/tracking/ActivityLifecycleTrackingStrategy.kt 95.65% <ø> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 73.21% <57.14%> (-18.85%) ⬇️
...oid/src/main/kotlin/com/datadog/android/Datadog.kt 81.95% <60.87%> (-0.01%) ⬇️
...n/com/datadog/android/core/internal/CoreFeature.kt 91.70% <88.89%> (+0.10%) ⬆️
...n/kotlin/com/datadog/android/DatadogInterceptor.kt 87.50% <100.00%> (+0.29%) ⬆️
...atadog/android/core/configuration/Configuration.kt 98.76% <100.00%> (+1.26%) ⬆️
...c/main/kotlin/com/datadog/android/rum/GlobalRum.kt 70.27% <100.00%> (+0.83%) ⬆️
...ndroid/rum/internal/domain/event/RumEventMapper.kt 94.23% <100.00%> (+0.23%) ⬆️
...id/rum/internal/domain/event/RumEventSerializer.kt 99.09% <100.00%> (+0.02%) ⬆️
... and 13 more

@0xnm
0xnm force-pushed the nogorodnikov/rumm-2476/target-android-13 branch from 57fe231 to caecde5 Compare November 8, 2022 10:18
@0xnm
0xnm changed the base branch from develop to nogorodnikov/filter-out-telemetry-in-instrumented-rum-tests-assertions November 8, 2022 11:25
@xgouchet xgouchet added the size-small This PR is small sized label Nov 8, 2022
Base automatically changed from nogorodnikov/filter-out-telemetry-in-instrumented-rum-tests-assertions to develop November 8, 2022 13:09
@0xnm
0xnm merged commit 7b66c9c into develop Nov 8, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-2476/target-android-13 branch November 8, 2022 13:34
@0xnm 0xnm mentioned this pull request Nov 9, 2022
Merged
3 tasks
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-small This PR is small sized

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @xgouchet