RUMM-2684: Observe uncaught exception in executors#1125
Merged
0xnm merged 1 commit intoNov 7, 2022
Merged
Conversation
Base automatically changed from
nogorodnikov/rumm-2700/use-eventwritecontext-for-logs
to
feature/sdkv2
November 4, 2022 09:47
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1125 +/- ##
=================================================
- Coverage 82.52% 82.44% -0.08%
=================================================
Files 347 349 +2
Lines 11355 11383 +28
Branches 1912 1914 +2
=================================================
+ Hits 9370 9384 +14
- Misses 1412 1419 +7
- Partials 573 580 +7
|
xgouchet
approved these changes
Nov 7, 2022
0xnm
deleted the
nogorodnikov/rumm-2684/observe_uncaught_exceptions_in_executors
branch
November 7, 2022 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Turns out we were swallowing uncaught exceptions raised during the execution of the tasks submitted via
Executor#execute,ExecutorService#submitorScheduledExecutorService#schedulecalls, because the behavior is like the following:Executor#execute, then worker thread is killed and exception is printed to the console.ExecutorService#submitorScheduledExecutorService#schedule, then worker thread is kept running and exception is thrown on the thread is which doingFuture#getcall (normally the thread getting the result). We were always ignoring theFuturereturned after the task is submitted, so we were swallowing such exceptions.This change closes this gap by adding the hook to the
ThreadPoolExecutor#afterExecutemethod, which allows to observe such uncaught exceptions.ThreadPoolExecutor#afterExecuteis called on the thread which did the actual task execution.The logic of this hook is taken from the afterExecute documentation.
Exceptions will be sent to the
devLoggerand to the internal telemetry as well.Review checklist (to be filled by reviewers)