Fix flaky ANR detection test#1123
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1123 +/- ##
===========================================
+ Coverage 83.24% 83.26% +0.02%
===========================================
Files 273 273
Lines 9372 9372
Branches 1504 1504
===========================================
+ Hits 7801 7803 +2
+ Misses 1153 1150 -3
- Partials 418 419 +1
|
mariusc83
approved these changes
Nov 3, 2022
xgouchet
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change fixes flaky test by adding a bit more delay for the main thread, because otherwise it seems it can continue the execution before the ANR detection thread (which is sleeping for the same amount of time here).
Review checklist (to be filled by reviewers)