Skip to content

Remove Flutter from Dogfooding scripts#1120

Merged
fuzzybinary merged 1 commit into
developfrom
jward/remove-flutter-dogfood
Nov 3, 2022
Merged

Remove Flutter from Dogfooding scripts#1120
fuzzybinary merged 1 commit into
developfrom
jward/remove-flutter-dogfood

Conversation

@fuzzybinary

Copy link
Copy Markdown
Member

What does this PR do?

Removes all dogfooding steps that push new versions to the Flutter repo.

Motivation

Flutter is now developing off source and will "pull" new versions when it deploys. This removes the Android step of "pushing" the new releases as that is no longer necessary

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary
fuzzybinary requested a review from a team as a code owner November 2, 2022 12:55
Comment thread dogfood.py
@codecov-commenter

codecov-commenter commented Nov 2, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1120 (6e7dcdc) into develop (8ba3c1f) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1120      +/-   ##
===========================================
+ Coverage    83.24%   83.29%   +0.05%     
===========================================
  Files          273      273              
  Lines         9372     9372              
  Branches      1504     1504              
===========================================
+ Hits          7801     7806       +5     
+ Misses        1153     1147       -6     
- Partials       418      419       +1     
Impacted Files Coverage Δ
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.57% <0.00%> (-1.62%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (+0.42%) ⬆️
...ain/java/com/datadog/opentracing/PendingTrace.java 57.76% <0.00%> (+1.72%) ⬆️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 86.96% <0.00%> (+4.35%) ⬆️
...ndroid/core/internal/persistence/file/EventMeta.kt 90.00% <0.00%> (+10.00%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+25.00%) ⬆️

Flutter is now developing off source and will "pull" new versions when it deploys. This removes the Android step of "pushing" the new releases.
@fuzzybinary
fuzzybinary force-pushed the jward/remove-flutter-dogfood branch from 8c772af to 6e7dcdc Compare November 2, 2022 20:29
@fuzzybinary

Copy link
Copy Markdown
Member Author

@0xnm Added a comment, let me know if that works for you.

@fuzzybinary
fuzzybinary merged commit a42e0f8 into develop Nov 3, 2022
@fuzzybinary
fuzzybinary deleted the jward/remove-flutter-dogfood branch November 3, 2022 13:12
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants