RUMM-2699: Remove RumEventSourceProvider#1119
Merged
0xnm merged 1 commit intoNov 3, 2022
Merged
Conversation
0xnm
marked this pull request as ready for review
November 2, 2022 10:50
Base automatically changed from
nogorodnikov/rumm-2602/use-event-write-context-for-rum
to
feature/sdkv2
November 2, 2022 10:52
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1119 +/- ##
=================================================
- Coverage 82.49% 82.43% -0.06%
=================================================
Files 348 348
Lines 11409 11380 -29
Branches 1910 1911 +1
=================================================
- Hits 9411 9380 -31
+ Misses 1421 1419 -2
- Partials 577 581 +4
|
0xnm
force-pushed
the
nogorodnikov/rumm-2699/remove-rumeventsourceprovider
branch
from
November 2, 2022 11:29
214ca9b to
9b2b3ab
Compare
0xnm
force-pushed
the
nogorodnikov/rumm-2699/remove-rumeventsourceprovider
branch
from
November 2, 2022 11:47
9b2b3ab to
0bab8ec
Compare
xgouchet
approved these changes
Nov 2, 2022
mariusc83
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change removes
RumEventSourceProvider, because we shouldn't accessCoreFeature(it won't be exposed as public API), so we cannot readCoreFeature#sourceNameat theDatadogRumMonitorconstruction time and should readDatadogContext#sourceinstead which is available in the Event Write Context.Calls to
RumEventSourceProviderare replaced by the companion extensions of the correspondingSourceobjects which try to parse the value fromDatadogContext#sourcein the safe manner.Review checklist (to be filled by reviewers)