RUMM-2602: Use event write context in RUM#1117
Merged
0xnm merged 1 commit intoNov 2, 2022
Merged
Conversation
0xnm
force-pushed
the
nogorodnikov/rumm-2602/use-event-write-context-for-rum
branch
from
October 31, 2022 17:05
edd4839 to
d71fe7b
Compare
0xnm
marked this pull request as ready for review
November 2, 2022 07:40
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1117 +/- ##
=================================================
+ Coverage 82.32% 82.49% +0.17%
=================================================
Files 352 348 -4
Lines 11426 11409 -17
Branches 1898 1910 +12
=================================================
+ Hits 9406 9411 +5
+ Misses 1442 1421 -21
+ Partials 578 577 -1
|
xgouchet
approved these changes
Nov 2, 2022
0xnm
deleted the
nogorodnikov/rumm-2602/use-event-write-context-for-rum
branch
November 2, 2022 10:52
This was referenced Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change brings the usage of event write context (EWC) to RUM (and to Web View RUM) and is similar to the move done in #1106, #1103.
Basically to write RUM events we now first request EWC via
FeatureScope#withWriteContextcall. This call is done at the very last point, so that the switch to the worker thread (where the closure is executed) doesn't affect the sequential flow and no changes to the shared state is done from the closure context.There are some things which still keep RUM bound to the crash reporting or to the core feature (like the need to get server time offset outside of EWC, etc.), they will be addressed in the other PRs.
Review checklist (to be filled by reviewers)