Skip to content

Fix WireframeUtils flaky tests#1113

Merged
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/fix-wireframeutils-test-flakiness
Oct 31, 2022
Merged

Fix WireframeUtils flaky tests#1113
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/fix-wireframeutils-test-flakiness

Conversation

@mariusc83

@mariusc83 mariusc83 commented Oct 31, 2022

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Oct 31, 2022
@mariusc83
mariusc83 requested a review from a team as a code owner October 31, 2022 09:03
@mariusc83
mariusc83 force-pushed the mconstantin/fix-wireframeutils-test-flakiness branch from 2676d76 to db1aa06 Compare October 31, 2022 09:29
@codecov-commenter

codecov-commenter commented Oct 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1113 (db1aa06) into feature/sdkv2 (6058fb0) will increase coverage by 0.07%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           feature/sdkv2    #1113      +/-   ##
=================================================
+ Coverage          82.32%   82.39%   +0.07%     
=================================================
  Files                352      352              
  Lines              11426    11426              
  Branches            1898     1898              
=================================================
+ Hits                9406     9414       +8     
  Misses              1442     1442              
+ Partials             578      570       -8
Impacted Files Coverage Δ
...android/log/internal/logger/TelemetryLogHandler.kt 75.00% <0.00%> (-25.00%) ⬇️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 95.83% <0.00%> (-4.17%) ⬇️
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-1.96%) ⬇️
...android/v2/core/internal/DatadogContextProvider.kt 83.58% <0.00%> (ø)
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.49% <0.00%> (+0.42%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.61% <0.00%> (+0.57%) ⬆️
...android/log/internal/domain/DatadogLogGenerator.kt 96.40% <0.00%> (+0.90%) ⬆️
...in/com/datadog/android/log/internal/LogsFeature.kt 88.71% <0.00%> (+1.61%) ⬆️
...ain/java/com/datadog/opentracing/PendingTrace.java 60.34% <0.00%> (+1.72%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.95% <0.00%> (+3.68%) ⬆️

@mariusc83
mariusc83 merged commit 4317825 into feature/sdkv2 Oct 31, 2022
@mariusc83
mariusc83 deleted the mconstantin/fix-wireframeutils-test-flakiness branch October 31, 2022 10:20
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

@mariusc83 mariusc83

Labels

size-tiny

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mariusc83 @codecov-commenter @0xnm @xgouchet