RUMM-2693 Increase the screen snapshot frequency#1110
Merged
mariusc83 merged 1 commit intoOct 31, 2022
Merged
Conversation
0xnm
approved these changes
Oct 28, 2022
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/sdkv2 #1110 +/- ##
=================================================
- Coverage 82.69% 82.42% -0.28%
=================================================
Files 350 352 +2
Lines 11301 11425 +124
Branches 1846 1898 +52
=================================================
+ Hits 9345 9416 +71
- Misses 1394 1440 +46
- Partials 562 569 +7
🚀 New features to boost your workflow:
|
mariusc83
deleted the
mconstantin/rumm-2693/adjust-screen-snapshot-frequency
branch
October 31, 2022 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When replaying scrolling effects the 16ms delay was too big as it could indefinitely postpone a snapshot during a continuous scrolling. We are currently lowering that to 4ms and based on the tests everything looks fine. During dogfooding we might need to adjust this value again or maybe just remove it but for performance reasons we will keep it for now.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)