Skip to content

Fix source key in SR upload form#1109

Merged
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/fix-source-key-in-sr-upload-form
Oct 28, 2022
Merged

Fix source key in SR upload form#1109
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/fix-source-key-in-sr-upload-form

Conversation

@mariusc83

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83
mariusc83 requested a review from a team as a code owner October 27, 2022 09:55
@codecov-commenter

codecov-commenter commented Oct 27, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.79%. Comparing base (18ad05c) to head (c421de4).

Additional details and impacted files
@@                Coverage Diff                @@
##           feature/sdkv2    #1109      +/-   ##
=================================================
+ Coverage          82.77%   82.79%   +0.02%     
=================================================
  Files                352      352              
  Lines              11366    11366              
  Branches            1865     1865              
=================================================
+ Hits                9408     9410       +2     
+ Misses              1397     1396       -1     
+ Partials             561      560       -1     
Files with missing lines Coverage Δ
...replay/internal/net/SessionReplayOkHttpUploader.kt 5.26% <ø> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from mconstantin/rumm-2689/sr-flush-touch-positions-every-n-milliseconds to feature/sdkv2 October 28, 2022 07:33
@mariusc83
mariusc83 merged commit 5b51d1d into feature/sdkv2 Oct 28, 2022
@mariusc83
mariusc83 deleted the mconstantin/fix-source-key-in-sr-upload-form branch October 28, 2022 08:09
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants