RUMM-2689 SR Flush buffered motion event positions periodically#1108
Merged
mariusc83 merged 1 commit intoOct 28, 2022
Conversation
0xnm
approved these changes
Oct 27, 2022
mariusc83
deleted the
mconstantin/rumm-2689/sr-flush-touch-positions-every-n-milliseconds
branch
October 28, 2022 07:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before for each intercepted gesture in SR we were buffering all the gesture
MotionEventsasTouchData.Positionfrom the moment we received theMotionEvent.ACTION_DOWNuntil the moment we received theMotionEvent.ACTION_UP.If the gesture was long enough this approach could create some glitches in the player (if you have a fragments view pager the gesture could start playing after half of the new fragment became visible already). In order to avoid this we will flush the buffer every 160 ms, equivalent to 16 frames. This is a heuristically determined value and probably we will adjust it during dogfooding.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)