RUMM-2682: Use event write context for Session Replay#1107
Merged
0xnm merged 1 commit intoOct 27, 2022
Merged
Conversation
0xnm
force-pushed
the
nogorodnikov/rumm-2682/use-event-write-context-for-session-replay
branch
from
October 26, 2022 16:05
3e79f86 to
3c3b040
Compare
mariusc83
approved these changes
Oct 27, 2022
0xnm
force-pushed
the
nogorodnikov/rumm-2607/use-eventwritecontext-for-logs
branch
from
October 27, 2022 11:44
cd86390 to
169cbec
Compare
Base automatically changed from
nogorodnikov/rumm-2607/use-eventwritecontext-for-logs
to
feature/sdkv2
October 27, 2022 12:36
xgouchet
approved these changes
Oct 27, 2022
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1107 +/- ##
=================================================
- Coverage 82.69% 82.36% -0.33%
=================================================
Files 350 350
Lines 11301 11355 +54
Branches 1846 1875 +29
=================================================
+ Hits 9345 9352 +7
- Misses 1394 1433 +39
- Partials 562 570 +8
|
0xnm
force-pushed
the
nogorodnikov/rumm-2682/use-event-write-context-for-session-replay
branch
from
October 27, 2022 13:24
3c3b040 to
3cd9096
Compare
0xnm
deleted the
nogorodnikov/rumm-2682/use-event-write-context-for-session-replay
branch
October 27, 2022 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR brings the usage of event write context (which can be retrieved by calling
withWriteContext) for Session Replay.There are places where context is not completely used (like
GlobalRumaccess or server time offset), but they will be addressed later, they have a dependency on some changes in RUM.Review checklist (to be filled by reviewers)