Deprecate DatadogPlugin class and its usage#1100
Conversation
a332cbc to
cb69cb8
Compare
xgouchet
left a comment
xgouchet
left a comment
There was a problem hiding this comment.
It'd be nice to also call the warnDeprecated(…) method. The deprecated annotation won't necessarily be seen and this will also write a warning in Logcat.
| "Datadog Plugins won't work in SDK v2, you'll need to write" + | ||
| " your own Feature" |
There was a problem hiding this comment.
| "Datadog Plugins won't work in SDK v2, you'll need to write" + | |
| " your own Feature" | |
| "Datadog Plugins will be removed in SDK v2.0.0." + | |
| "You will then need to write your own Feature (check our own code for guidance)." |
There was a problem hiding this comment.
The problem is that there is no code to check for the guidance, it will be available (with all the public API changes) in version 2.0.0, so that it means we cannot remove things related to the DatadogPlugin in 2.0.0 and should do it later at some point. WDYT? In theory it is not a problem to keep DatadogPlugin a bit longer. Or we don't add the statement about checking the code.
There was a problem hiding this comment.
Well we will (do) have some features implementation in the SDK v2 branch. Saying that "you'll need to write your own feature" without giving a doc on how to do it is going to be frustrating to customers when they see this warning.
| * @see [Feature.TRACE] | ||
| * @see [Feature.RUM] | ||
| */ | ||
| @Deprecated("Datadog Plugins won't work in SDK v2, you'll need to write your own Feature") |
There was a problem hiding this comment.
| @Deprecated("Datadog Plugins won't work in SDK v2, you'll need to write your own Feature") | |
| "Datadog Plugins will be removed in SDK v2.0.0." + | |
| "You will then need to write your own Feature (check our own code for guidance)." |
| } | ||
| } | ||
|
|
||
| @Deprecated("Plugins won't work that way in SDK v2") |
There was a problem hiding this comment.
| @Deprecated("Plugins won't work that way in SDK v2") | |
| "Datadog Plugins will be removed in SDK v2.0.0." + | |
| "You will then need to write your own Feature (check our own code for guidance)." |
Codecov Report
@@ Coverage Diff @@
## develop #1100 +/- ##
===========================================
+ Coverage 83.29% 83.29% +0.01%
===========================================
Files 273 273
Lines 9363 9367 +4
Branches 1503 1503
===========================================
+ Hits 7798 7802 +4
- Misses 1147 1149 +2
+ Partials 418 416 -2
|
cb69cb8 to
92161fb
Compare
4 participants
What does this PR do?
This was done already in SDK v2 branch, just doing the same in the
develop, so that it can be in the 1.x releases.Review checklist (to be filled by reviewers)