RUMM-2674: Make implementations of EventBatchWriter return result instead of using listener#1097
Merged
0xnm merged 1 commit intoOct 21, 2022
Conversation
…tead of using listener
xgouchet
approved these changes
Oct 21, 2022
mariusc83
approved these changes
Oct 21, 2022
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1097 +/- ##
=================================================
- Coverage 82.66% 82.56% -0.10%
=================================================
Files 349 349
Lines 11229 11224 -5
Branches 1838 1837 -1
=================================================
- Hits 9282 9267 -15
- Misses 1388 1395 +7
- Partials 559 562 +3
|
0xnm
deleted the
nogorodnikov/rumm-2674/implementations-of-eventbatchwriter-sync
branch
October 21, 2022 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implementations of
EventBatchWriterare not supposed to switch the thread, becauseStorage#writeCurrentBatchis going to do that. Considering that, we can assume that implementationsEventBatchWriterwill be synchronous and can simply return result of the write operation instead of using the listener.Review checklist (to be filled by reviewers)