Add version to top level project for nexusPublishing extension#1096
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1096 +/- ##
===========================================
- Coverage 83.27% 83.23% -0.04%
===========================================
Files 273 273
Lines 9348 9348
Branches 1503 1503
===========================================
- Hits 7784 7780 -4
- Misses 1146 1151 +5
+ Partials 418 417 -1
|
fuzzybinary
force-pushed
the
RUMM-2579-snapshot-builds
branch
from
October 20, 2022 18:20
a85a13d to
21cf147
Compare
0xnm
approved these changes
Oct 21, 2022
xgouchet
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It appears the nexusPublishing extension only evaluates whether a deployment goes to staging or not at the Project level, so we need to add the version at that level in order for snapshot builds to go through
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)