Skip to content

MTG-6 Update ktlint to 0.47.1#1091

Merged
daniel-m-dd merged 4 commits into
developfrom
d.marin/ktlint
Oct 21, 2022
Merged

MTG-6 Update ktlint to 0.47.1#1091
daniel-m-dd merged 4 commits into
developfrom
d.marin/ktlint

Conversation

@daniel-m-dd

@daniel-m-dd daniel-m-dd commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Update Ktlint to 0.47.1

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)


package com.datadog.gradle.plugin.checklicenses

@Suppress("ktlint:enum-entry-name-case")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppressing the check here as I dont think it is worth modifying all enum variables defined here...

@daniel-m-dd daniel-m-dd changed the title Update ktlint to 0.47.1 [NOT READY TO BE MERGED] Update ktlint to 0.47.1 Oct 18, 2022

@xgouchet xgouchet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll try and update the file generator to generate proper format

@xgouchet xgouchet changed the title [NOT READY TO BE MERGED] Update ktlint to 0.47.1 [NOT READY TO BE MERGED] MTG-6 Update ktlint to 0.47.1 Oct 20, 2022
@xgouchet xgouchet added the size-small This PR is small sized label Oct 21, 2022
@daniel-m-dd daniel-m-dd changed the title [NOT READY TO BE MERGED] MTG-6 Update ktlint to 0.47.1 MTG-6 Update ktlint to 0.47.1 Oct 21, 2022
@daniel-m-dd
daniel-m-dd marked this pull request as ready for review October 21, 2022 00:57
@daniel-m-dd
daniel-m-dd requested a review from a team as a code owner October 21, 2022 00:57
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1091 (1323bec) into develop (3f38162) will decrease coverage by 0.07%.
The diff coverage is 86.67%.

@@             Coverage Diff             @@
##           develop    #1091      +/-   ##
===========================================
- Coverage    83.27%   83.20%   -0.07%     
===========================================
  Files          273      273              
  Lines         9348     9363      +15     
  Branches      1503     1503              
===========================================
+ Hits          7784     7790       +6     
- Misses        1146     1150       +4     
- Partials       418      423       +5     
Impacted Files Coverage Δ
...om/datadog/android/core/internal/utils/MapUtils.kt 100.00% <ø> (ø)
...g/android/rum/internal/domain/scope/RumEventExt.kt 93.20% <0.00%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 92.06% <80.00%> (+0.13%) ⬆️
...kotlin/com/datadog/android/DatadogEventListener.kt 98.51% <100.00%> (ø)
...ore/internal/constraints/DatadogDataConstraints.kt 94.67% <100.00%> (ø)
...id/core/internal/data/upload/DataUploadRunnable.kt 100.00% <100.00%> (ø)
...l/net/info/BroadcastReceiverNetworkInfoProvider.kt 92.93% <100.00%> (ø)
.../android/core/internal/persistence/file/FileExt.kt 100.00% <100.00%> (ø)
...android/tracing/internal/utils/TracerExtensions.kt 100.00% <100.00%> (ø)
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 82.61% <0.00%> (-4.35%) ⬇️
... and 3 more

@daniel-m-dd
daniel-m-dd merged commit abb21ef into develop Oct 21, 2022
@daniel-m-dd
daniel-m-dd deleted the d.marin/ktlint branch October 21, 2022 07:37
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-small This PR is small sized

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants